Repository navigation
fix: Set better Chart Axis Bounds - #1585
Merged
Merged
Conversation
🦋 Changeset detectedLatest commit: 35cb617 The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Code Review✅ No critical issues found. The changes properly fix chart axis bounds with clean implementation: Strengths:
Minor observations:
Changes are well-contained and safe to merge. |
Contributor
E2E Test Results✅ All tests passed • 59 passed • 4 skipped • 864s
Tests ran across 4 shards in parallel. |
pulpdrew
force-pushed
the
drew/axis-bounds
branch
from
January 9, 2026 20:25
d5c4c47 to
35cb617
Compare
pulpdrew
requested review from
a team and
knudtty
and removed request for
a team
January 9, 2026 20:44
knudtty
pushed a commit
that referenced
this pull request
Apr 16, 2026
Closes HDX-3180 # Summary This PR makes a couple of changes to TimeChart axis bounds 1. Y Axis lower bound is now always 0 unless a series is selected (partial revert of #1572) 2. X-Axis bounds have been adjusted so that 1. There is no longer an empty partial interval's worth of space at the end of line charts 2. The first bar of a bar chart no longer overlaps with the Y Axis ## Before - The first Bar in bar charts overlaps the Y Axis <img width="1600" height="495" alt="Screenshot 2026-01-09 at 2 55 27 PM" src="https://github.com/user-attachments/assets/13087084-4847-46d5-98d3-85340101d7f3" /> - There is an empty partial (or full) interval at the end of charts <img width="1611" height="483" alt="Screenshot 2026-01-09 at 2 55 21 PM" src="https://github.com/user-attachments/assets/a286966b-ccfa-485c-8d26-7090f75120e0" /> - Y Axis lower bound is non-zero when no series are selected <img width="1603" height="388" alt="Screenshot 2026-01-09 at 2 38 54 PM" src="https://github.com/user-attachments/assets/4ca2743a-d484-40b1-b2e6-352aad838070" /> <img width="1623" height="373" alt="Screenshot 2026-01-09 at 2 37 26 PM" src="https://github.com/user-attachments/assets/4a8b9490-9efb-4c75-93b4-edb3321ee0a2" /> ## After - Bars fit fully within the chart domain <img width="1610" height="503" alt="Screenshot 2026-01-09 at 2 55 42 PM" src="https://github.com/user-attachments/assets/42ab1f62-4c1e-475f-b3be-4bf6ed147dc4" /> - There is no empty space at the end of the line charts - Y Axis lower bound is always 0 when no series are selected <img width="1613" height="490" alt="Screenshot 2026-01-09 at 2 55 50 PM" src="https://github.com/user-attachments/assets/ed723a99-2a24-47f2-8ac8-93901f7fbf88" />
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes HDX-3180
Summary
This PR makes a couple of changes to TimeChart axis bounds
Before
After